Paths

Table of Contentst

Encode username and password correctly in PhutilURI
ClosedPublic
Actions

Authored by epriestley on Feb 5 2014, 5:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 10, 5:01 AM

	Unknown Object (File)
	Sun, Feb 9, 11:20 AM

	Unknown Object (File)
	Sun, Feb 9, 11:20 AM

	Unknown Object (File)
	Sun, Feb 9, 11:20 AM

	Unknown Object (File)
	Sun, Feb 9, 11:20 AM

	Unknown Object (File)
	Fri, Feb 7, 12:40 AM

	Unknown Object (File)
	Thu, Jan 30, 7:39 PM

	Unknown Object (File)
	Wed, Jan 29, 5:45 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4374: Password strings do not seem to be escaped properly

Commits

rPHU9e85344d3ffb: Encode username and password correctly in PhutilURI

Summary

Fixes T4374. We do not encode passwords in URIs correctly, so passwords with, e.g., the @ character do not work correctly.

Test Plan

Added unit tests.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Feb 5 2014, 10:13 PM

Closed by commit rPHU9e85344d3ffb (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

PhutilURI.php

13 lines

__tests__/

PhutilURITestCase.php

20 lines

Diff 18445

View Options

src/parser/PhutilURI.php

View Options

src/parser/tests/PhutilURITestCase.php

Encode username and password correctly in PhutilURIClosedPublicActions