Paths

Table of Contentst

Encode username and password correctly in PhutilURI
ClosedPublic
Actions

Authored by epriestley on Feb 5 2014, 5:10 PM.

Tags

None

Referenced Files

	F13993191: D8144.id.diff
	Tue, Oct 22, 9:17 PM

	F13985097: D8144.diff
	Sun, Oct 20, 6:01 PM

	F13981860: D8144.id18429.diff
	Sat, Oct 19, 7:31 PM

	F13972546: D8144.id18445.diff
	Thu, Oct 17, 7:39 PM

	Unknown Object (File)
	Oct 4 2024, 11:30 AM

	Unknown Object (File)
	Oct 2 2024, 9:23 AM

	Unknown Object (File)
	Oct 2 2024, 4:31 AM

	Unknown Object (File)
	Oct 2 2024, 12:25 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4374: Password strings do not seem to be escaped properly

Commits

rPHU9e85344d3ffb: Encode username and password correctly in PhutilURI

Summary

Fixes T4374. We do not encode passwords in URIs correctly, so passwords with, e.g., the @ character do not work correctly.

Test Plan

Added unit tests.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Feb 5 2014, 10:13 PM

Closed by commit rPHU9e85344d3ffb (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

PhutilURI.php

13 lines

__tests__/

PhutilURITestCase.php

20 lines

Diff 18445

View Options

src/parser/PhutilURI.php

View Options

src/parser/tests/PhutilURITestCase.php

Encode username and password correctly in PhutilURIClosedPublicActions