Fix Maniphest status change previews
ClosedPublic
Actions

Authored by epriestley on Jan 29 2014, 6:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 31, 9:54 AM

	Unknown Object (File)
	Thu, Aug 29, 9:27 PM

	Unknown Object (File)
	Fri, Aug 16, 6:00 AM

	Unknown Object (File)
	Wed, Aug 14, 1:01 AM

	Unknown Object (File)
	Wed, Aug 14, 12:59 AM

	Unknown Object (File)
	Wed, Aug 14, 12:58 AM

	Unknown Object (File)
	Wed, Aug 14, 12:57 AM

	Unknown Object (File)
	Mon, Aug 12, 7:31 PM

View All Files

Subscribers

aran

mbishopim3

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rPd504a4d7df42: Fix Maniphest status change previews

Summary

See IRC. This will be obsoleted by ApplicationTransactions eventually, but fix issues with stauts change previews for now. Specifically, if you select "Reopen Task", it incorrectly previews as "x created this task" because the old state is not set correctly.

Test Plan

Selected "Reopen Task", saw a preview with the correct language.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad accepted this revision.Jan 29 2014, 6:40 PM

Closed by commit rPd504a4d7df42 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestTransactionPreviewController.php

5 lines

Diff 18314

View Options

src/applications/maniphest/controller/ManiphestTransactionPreviewController.php

Fix Maniphest status change previewsClosedPublicActions