Page MenuHomePhabricator

Restore "project.name" (previously "project_id") to .arcconfig for arcanist
ClosedPublic

Authored by epriestley on Jan 26 2014, 11:42 PM.
Tags
None
Referenced Files
F13264934: D8076.diff
Mon, May 27, 11:32 PM
F13248658: D8076.diff
Fri, May 24, 3:48 AM
F13245928: D8076.diff
Thu, May 23, 6:43 AM
F13217541: D8076.id.diff
Sat, May 18, 6:13 AM
F13200704: D8076.diff
Tue, May 14, 2:45 AM
F13182337: D8076.diff
Thu, May 9, 11:24 PM
Unknown Object (File)
Apr 30 2024, 10:52 AM
Unknown Object (File)
Apr 26 2024, 2:24 PM
Subscribers

Details

Summary

A couple of things actually still care about this:

  • The code that detects if we're running arc on arc, and then runs the arc we're running on instead of the arc we ran, checks for the project being "arcanist" (reenter_if_this_is_arcanist_or_libphutil()).
  • Some of the symbol stuff still relies on it.
  • Removing it was really more to prove it works (which it seems to) than to accomplish any concrete goals.
Test Plan

looked at the file I guess

Diff Detail

Repository
rARC Arcanist
Branch
arcname
Lint
Lint Passed
Unit
No Test Coverage