Page MenuHomePhabricator

Restore "project.name" (previously "project_id") to .arcconfig for arcanist
ClosedPublic

Authored by epriestley on Jan 26 2014, 11:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 12, 11:46 AM
Unknown Object (File)
Sat, Feb 8, 1:11 PM
Unknown Object (File)
Mon, Feb 3, 11:30 AM
Unknown Object (File)
Wed, Jan 22, 10:42 PM
Unknown Object (File)
Tue, Jan 21, 9:02 AM
Unknown Object (File)
Sat, Jan 18, 2:05 AM
Unknown Object (File)
Dec 20 2024, 10:05 AM
Unknown Object (File)
Dec 20 2024, 10:05 AM
Subscribers

Details

Summary

A couple of things actually still care about this:

  • The code that detects if we're running arc on arc, and then runs the arc we're running on instead of the arc we ran, checks for the project being "arcanist" (reenter_if_this_is_arcanist_or_libphutil()).
  • Some of the symbol stuff still relies on it.
  • Removing it was really more to prove it works (which it seems to) than to accomplish any concrete goals.
Test Plan

looked at the file I guess

Diff Detail

Repository
rARC Arcanist
Branch
arcname
Lint
Lint Passed
Unit
No Test Coverage