Page MenuHomePhabricator

Restore "project.name" (previously "project_id") to .arcconfig for arcanist
ClosedPublic

Authored by epriestley on Jan 26 2014, 11:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 8:25 PM
Unknown Object (File)
Wed, Nov 20, 1:12 PM
Unknown Object (File)
Oct 18 2024, 4:48 PM
Unknown Object (File)
Oct 15 2024, 12:08 AM
Unknown Object (File)
Oct 12 2024, 4:28 AM
Unknown Object (File)
Sep 21 2024, 7:14 AM
Unknown Object (File)
Sep 21 2024, 4:38 AM
Unknown Object (File)
Aug 26 2024, 5:25 AM
Subscribers

Details

Summary

A couple of things actually still care about this:

  • The code that detects if we're running arc on arc, and then runs the arc we're running on instead of the arc we ran, checks for the project being "arcanist" (reenter_if_this_is_arcanist_or_libphutil()).
  • Some of the symbol stuff still relies on it.
  • Removing it was really more to prove it works (which it seems to) than to accomplish any concrete goals.
Test Plan

looked at the file I guess

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped