Page MenuHomePhabricator

Restore "project.name" (previously "project_id") to .arcconfig for arcanist
ClosedPublic

Authored by epriestley on Jan 26 2014, 11:42 PM.
Tags
None
Referenced Files
F13182337: D8076.diff
Thu, May 9, 11:24 PM
Unknown Object (File)
Tue, Apr 30, 10:52 AM
Unknown Object (File)
Fri, Apr 26, 2:24 PM
Unknown Object (File)
Mon, Apr 22, 11:41 AM
Unknown Object (File)
Fri, Apr 12, 1:46 PM
Unknown Object (File)
Fri, Apr 12, 4:40 AM
Unknown Object (File)
Fri, Apr 12, 4:39 AM
Unknown Object (File)
Fri, Apr 12, 4:07 AM
Subscribers

Details

Summary

A couple of things actually still care about this:

  • The code that detects if we're running arc on arc, and then runs the arc we're running on instead of the arc we ran, checks for the project being "arcanist" (reenter_if_this_is_arcanist_or_libphutil()).
  • Some of the symbol stuff still relies on it.
  • Removing it was really more to prove it works (which it seems to) than to accomplish any concrete goals.
Test Plan

looked at the file I guess

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped