When repairing Git remote URIs, include credentials
ClosedPublic
Actions

Authored by epriestley on Jan 24 2014, 1:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 16, 5:42 AM

	Unknown Object (File)
	Sun, Feb 2, 10:23 AM

	Unknown Object (File)
	Tue, Jan 28, 5:40 AM

	Unknown Object (File)
	Tue, Jan 28, 5:39 AM

	Unknown Object (File)
	Fri, Jan 24, 6:01 AM

	Unknown Object (File)
	Wed, Jan 22, 12:52 PM

	Unknown Object (File)
	Jan 21 2025, 11:35 AM

	Unknown Object (File)
	Jan 21 2025, 9:00 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPc21a8d31dde2: When repairing Git remote URIs, include credentials

Summary

See IRC. Currently, if a fetch fails, we may repair the remote URI incorrectly, replacing it with one without any credentials. Instead, retain credentials.

Test Plan

Faked it locally, got le-boom to verify on IRC.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Jan 24 2014, 1:22 AM

Closed by commit rPc21a8d31dde2 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryPullEngine.php

6 lines

Diff 18224

View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

When repairing Git remote URIs, include credentialsClosedPublicActions