When repairing Git remote URIs, include credentials
ClosedPublic
Actions

Authored by epriestley on Jan 24 2014, 1:22 AM.

Tags

None

Referenced Files

	F13818153: D8055.diff
	Fri, Sep 20, 5:41 AM

	Unknown Object (File)
	Wed, Sep 4, 1:40 AM

	Unknown Object (File)
	Wed, Aug 28, 5:05 PM

	Unknown Object (File)
	Wed, Aug 28, 2:46 PM

	Unknown Object (File)
	Sat, Aug 24, 8:16 AM

	Unknown Object (File)
	Sat, Aug 24, 8:16 AM

	Unknown Object (File)
	Sat, Aug 24, 8:16 AM

	Unknown Object (File)
	Thu, Aug 22, 10:49 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPc21a8d31dde2: When repairing Git remote URIs, include credentials

Summary

See IRC. Currently, if a fetch fails, we may repair the remote URI incorrectly, replacing it with one without any credentials. Instead, retain credentials.

Test Plan

Faked it locally, got le-boom to verify on IRC.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Jan 24 2014, 1:22 AM

Closed by commit rPc21a8d31dde2 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryPullEngine.php

6 lines

Diff 18224

View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

When repairing Git remote URIs, include credentialsClosedPublicActions