Page MenuHomePhabricator

Do not perform write in PhabricatorDaemonLogQuery by default
ClosedPublic

Authored by epriestley on Jan 21 2014, 4:01 PM.
Tags
None
Referenced Files
F15386960: D8023.diff
Sat, Mar 15, 1:34 AM
F15382502: D8023.diff
Fri, Mar 14, 12:44 PM
F15288858: D8023.id.diff
Tue, Mar 4, 9:06 PM
Unknown Object (File)
Sat, Mar 1, 9:49 AM
Unknown Object (File)
Mon, Feb 24, 4:57 AM
Unknown Object (File)
Sat, Feb 22, 1:24 AM
Unknown Object (File)
Thu, Feb 20, 11:32 AM
Unknown Object (File)
Sat, Feb 15, 10:47 PM
Subscribers

Details

Summary

See http://github.com/facebook/phabricator/issues/487. By default, we perform a write in this query to moved daemons to "dead" status after a timeout. This is normally reasonable, but after D7964 we do a setup check against the daemons, which means this query is invoked very early in the stack, before we have a write guard.

Since doing this write unconditionally is unnecessarily, surprising, and overly ambitious, make the write conditional and do not attempt to perform it from the setup check.

(We could also move this to a GC/cron sort of thing eventually, maybe -- it's a bit awkward here, but we don't have other infrastructure which is a great fit right now.)

Test Plan

Hit setup issues and daemon pages. Will confirm with user that this fixes things.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped