HomePhabricator

Do not perform write in PhabricatorDaemonLogQuery by default

Description

Do not perform write in PhabricatorDaemonLogQuery by default

Summary:
See http://github.com/facebook/phabricator/issues/487. By default, we perform a write in this query to moved daemons to "dead" status after a timeout. This is normally reasonable, but after D7964 we do a setup check against the daemons, which means this query is invoked very early in the stack, before we have a write guard.

Since doing this write unconditionally is unnecessarily, surprising, and overly ambitious, make the write conditional and do not attempt to perform it from the setup check.

(We could also move this to a GC/cron sort of thing eventually, maybe -- it's a bit awkward here, but we don't have other infrastructure which is a great fit right now.)

Test Plan: Hit setup issues and daemon pages. Will confirm with user that this fixes things.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D8023

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Jan 21 2014, 10:04 PM
Reviewer
btrahan
Differential Revision
D8023: Do not perform write in PhabricatorDaemonLogQuery by default
Parents
rP56bcb33a1891: Improve exception reporting behavior for core exceptions
Branches
Unknown
Tags
Unknown

Event Timeline