Page MenuHomePhabricator

Move repository URI normalization out of PullLocalDaemon
ClosedPublic

Authored by epriestley on Jan 16 2014, 6:54 PM.
Tags
None
Referenced Files
F14057854: D7981.diff
Sun, Nov 17, 7:21 AM
F14020456: D7981.id18084.diff
Wed, Nov 6, 12:36 AM
F14020455: D7981.id18057.diff
Wed, Nov 6, 12:36 AM
F14020454: D7981.id.diff
Wed, Nov 6, 12:36 AM
F14016885: D7981.diff
Mon, Nov 4, 10:52 AM
F14013952: D7981.id.diff
Sat, Nov 2, 8:07 PM
F13982181: D7981.diff
Oct 19 2024, 9:41 PM
F13981335: D7981.id.diff
Oct 19 2024, 3:51 PM
Subscribers

Details

Summary

Ref T4327. Moves us one small step forward toward testable change parsers by separating out this unrelated logic from the PullLocal daemon. We will also probably want to run this logic so we can do remote path lookups to limit the role of Arcanist Projects in the future, which is why I made the URI type (here, only "git") a parameter rather than calling this a GitURINormalizer or something.

Test Plan
  • Ran unit tests.
  • Ran repository discover on a correctly-configured remote repository.
  • Ran repository discover on an incorrectly-configured remote, got an error message.

Diff Detail

Branch
xparser1
Lint
Lint Passed
Unit
Tests Passed