HomePhabricator

Move repository URI normalization out of PullLocalDaemon

Description

Move repository URI normalization out of PullLocalDaemon

Summary: Ref T4327. Moves us one small step forward toward testable change parsers by separating out this unrelated logic from the PullLocal daemon. We will also probably want to run this logic so we can do remote path lookups to limit the role of Arcanist Projects in the future, which is why I made the URI type (here, only "git") a parameter rather than calling this a GitURINormalizer or something.

Test Plan:

  • Ran unit tests.
  • Ran repository discover on a correctly-configured remote repository.
  • Ran repository discover on an incorrectly-configured remote, got an error message.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4327

Differential Revision: https://secure.phabricator.com/D7981

Details

Provenance
epriestleyAuthored on Jan 16 2014, 6:49 PM
epriestleyPushed on Jan 17 2014, 7:48 PM
Reviewer
btrahan
Differential Revision
D7981: Move repository URI normalization out of PullLocalDaemon
Parents
rPb26918aae1b4: unbreak trunk - silly typo from D7986
Branches
Unknown
Tags
Unknown
Tasks
T4327: Problems trying to import project

Event Timeline