Page MenuHomePhabricator

Separate session management from PhabricatorUser
ClosedPublic

Authored by epriestley on Jan 14 2014, 7:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 26 2024, 1:58 AM
Unknown Object (File)
Dec 28 2023, 4:33 PM
Unknown Object (File)
Dec 24 2023, 4:43 PM
Unknown Object (File)
Dec 21 2023, 9:42 AM
Unknown Object (File)
Dec 19 2023, 12:15 PM
Unknown Object (File)
Dec 18 2023, 5:00 AM
Unknown Object (File)
Dec 17 2023, 4:06 PM
Unknown Object (File)
Nov 24 2023, 10:15 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
T4310: Allow external users to establish real sessions
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPeef314b70149: Separate session management from PhabricatorUser
Summary

Ref T4310. Ref T3720. Session operations are currently part of PhabricatorUser. This is more tightly coupled than needbe, and makes it difficult to establish login sessions for non-users. Move all the session management code to a SessionEngine.

Test Plan
  • Viewed sessions.
  • Regenerated Conduit certificate.
  • Verified Conduit sessions were destroyed.
  • Logged out.
  • Logged in.
  • Ran conduit commands.
  • Viewed sessions again.

Diff Detail

Branch
auth3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/auth/storage/PhabricatorAuthSession.php:40XHP16TODO Comment
Unit
Tests Passed