Page MenuHomePhabricator

Separate session management from PhabricatorUser
ClosedPublic

Authored by epriestley on Jan 14 2014, 7:44 PM.

Details

Reviewers
btrahan
Maniphest Tasks
T4310: Allow external users to establish real sessions
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPeef314b70149: Separate session management from PhabricatorUser
Summary

Ref T4310. Ref T3720. Session operations are currently part of PhabricatorUser. This is more tightly coupled than needbe, and makes it difficult to establish login sessions for non-users. Move all the session management code to a SessionEngine.

Test Plan
  • Viewed sessions.
  • Regenerated Conduit certificate.
  • Verified Conduit sessions were destroyed.
  • Logged out.
  • Logged in.
  • Ran conduit commands.
  • Viewed sessions again.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

btrahan accepted this revision.Jan 14 2014, 9:06 PM
epriestley closed this revision.Jan 14 2014, 9:22 PM

Closed by commit rPeef314b70149 (authored by @epriestley).