Page MenuHomePhabricator

Added `ArcanistTextLinter::LINT_BOF_WHITESPACE` and `ArcanistTextLinter::LINT_EOF_WHITESPACE`
ClosedPublic

Authored by joshuaspence on Jan 14 2014, 1:41 AM.
Tags
None
Referenced Files
F14950724: D7957.id18001.diff
Sat, Feb 15, 10:47 PM
Unknown Object (File)
Tue, Feb 4, 3:02 AM
Unknown Object (File)
Wed, Jan 29, 8:00 AM
Unknown Object (File)
Tue, Jan 21, 9:51 AM
Unknown Object (File)
Tue, Jan 21, 9:01 AM
Unknown Object (File)
Mon, Jan 20, 7:27 AM
Unknown Object (File)
Jan 5 2025, 4:15 PM
Unknown Object (File)
Jan 5 2025, 3:01 PM

Details

Summary

This might not be universally desireable, but I found myself writing an additional linter (which I had called WhitespaceTextLinter) for the sake of these two linter tests. I figured it may be of use upstream, and so I decided to submit it as a diff. I won't be offended if it is rejected however.

Test Plan

arc lint and arc unit are both okay with it.

Diff Detail

Branch
text_linter
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

joshuaspence updated this revision to Unknown Object (????).Jan 14 2014, 1:54 AM

Used arc lint to demonstrate the changes.

These rules seem reasonable to me, happy to bring them to the upstream. Thanks!