Paths

Table of Contentst

Fix Herald field type error
ClosedPublic
Actions

Authored by epriestley on Jan 13 2014, 8:13 PM.

Tags

None

Referenced Files

	F15524611: D7950.diff
	Mon, Apr 21, 9:11 AM

	F15465790: D7950.id.diff
	Wed, Apr 2, 11:10 PM

	F15461921: D7950.id17997.diff
	Tue, Apr 1, 12:20 PM

	F15459843: D7950.diff
	Mon, Mar 31, 5:27 PM

	F15449729: D7950.id17978.diff
	Fri, Mar 28, 11:53 AM

	F15412998: D7950.id.diff
	Mar 19 2025, 4:17 PM

	F15387582: D7950.id.diff
	Mar 15 2025, 2:39 AM

	F15332086: D7950.diff
	Mar 7 2025, 4:29 PM

View All Files

Subscribers

aran

dctrwatson

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP6cc5f952a4cf: Fix Herald field type error

Summary

See IRC. This is a likely fix for @dctrwatson's error: we're returning null but should return array() to indicate no values.

Test Plan

Will make @dctrwatson do it.

Diff Detail

Branch

herald1

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

twothumbsup

fixes my issue

btrahan accepted this revision.Jan 14 2014, 12:04 AM

Closed by commit rP6cc5f952a4cf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldDifferentialRevisionAdapter.php

2 lines

Diff 17978

View Options

src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php

Fix Herald field type errorClosedPublicActions