Fix Herald field type error
ClosedPublic
Actions

Authored by epriestley on Jan 13 2014, 8:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 22, 10:38 PM

	Unknown Object (File)
	Sat, Apr 20, 10:14 AM

	Unknown Object (File)
	Mon, Apr 15, 11:54 PM

	Unknown Object (File)
	Thu, Apr 11, 7:31 AM

	Unknown Object (File)
	Sat, Apr 6, 4:56 AM

	Unknown Object (File)
	Sat, Apr 6, 4:56 AM

	Unknown Object (File)
	Sat, Apr 6, 4:21 AM

	Unknown Object (File)
	Sat, Apr 6, 4:00 AM

View All 92 Files

Subscribers

aran

dctrwatson

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP6cc5f952a4cf: Fix Herald field type error

Summary

See IRC. This is a likely fix for @dctrwatson's error: we're returning null but should return array() to indicate no values.

Test Plan

Will make @dctrwatson do it.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

twothumbsup

fixes my issue

btrahan accepted this revision.Jan 14 2014, 12:04 AM

Closed by commit rP6cc5f952a4cf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldDifferentialRevisionAdapter.php

2 lines

Diff 17997

View Options

src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php

Fix Herald field type errorClosedPublicActions