Fix Herald field type error
ClosedPublic
Actions

Authored by epriestley on Jan 13 2014, 8:13 PM.

Tags

None

Referenced Files

	F18761460: D7950.id.diff
	Mon, Oct 6, 2:27 PM

	F18716901: D7950.id17997.diff
	Mon, Sep 29, 12:51 PM

	F18607418: D7950.id.diff
	Sep 13 2025, 11:56 PM

	F18593479: D7950.diff
	Sep 12 2025, 3:02 PM

	F18089218: D7950.id17997.diff
	Aug 6 2025, 10:46 AM

	F18086996: D7950.id.diff
	Aug 6 2025, 1:42 AM

	Unknown Object (File)
	Jun 30 2025, 11:01 AM

	Unknown Object (File)
	Jun 29 2025, 3:30 PM

View All Files

Subscribers

aran

dctrwatson

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP6cc5f952a4cf: Fix Herald field type error

Summary

See IRC. This is a likely fix for @dctrwatson's error: we're returning null but should return array() to indicate no values.

Test Plan

Will make @dctrwatson do it.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

twothumbsup

fixes my issue

btrahan accepted this revision.Jan 14 2014, 12:04 AM

Closed by commit rP6cc5f952a4cf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldDifferentialRevisionAdapter.php

2 lines

Diff 17997

View Options

src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php

Fix Herald field type errorClosedPublicActions