Page MenuHomePhabricator

Fix two edge case issues with Differential mail tags
ClosedPublic

Authored by epriestley on Jan 9 2014, 1:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 11:09 PM
Unknown Object (File)
Sat, Jan 25, 7:01 PM
Unknown Object (File)
Jan 15 2025, 12:35 PM
Unknown Object (File)
Dec 13 2024, 11:31 AM
Unknown Object (File)
Dec 11 2024, 7:47 AM
Unknown Object (File)
Dec 8 2024, 6:21 AM
Unknown Object (File)
Nov 21 2024, 10:32 AM
Unknown Object (File)
Nov 10 2024, 8:46 PM
Subscribers

Details

Summary

Via Asana. The tags on Differential mail are wrong in two cases:

  • Transactions which submit inline comments but no comment text are not labeled as "comments", but should be.
  • Non-close, non-comment transactions are not labeled at all, but should be labeled "other".
Test Plan

Submitted a no-comments, inlines-only transaction and got a message with proper X-Phabricator-Mail-Tags header.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped