Page MenuHomePhabricator

Fix two edge case issues with Differential mail tags
ClosedPublic

Authored by epriestley on Jan 9 2014, 1:53 AM.
Tags
None
Referenced Files
F19233350: D7912.id17909.diff
Sun, Dec 21, 5:39 PM
F18853330: D7912.id17926.diff
Oct 31 2025, 3:51 PM
F18789093: D7912.diff
Oct 15 2025, 7:56 AM
F18642241: D7912.id.diff
Sep 18 2025, 11:10 PM
F18575789: D7912.id.diff
Sep 10 2025, 2:07 PM
F18564362: D7912.diff
Sep 9 2025, 9:46 AM
F17743972: D7912.id17909.diff
Jul 21 2025, 2:58 PM
F17738938: D7912.id17926.diff
Jul 21 2025, 1:16 AM
Subscribers

Details

Summary

Via Asana. The tags on Differential mail are wrong in two cases:

  • Transactions which submit inline comments but no comment text are not labeled as "comments", but should be.
  • Non-close, non-comment transactions are not labeled at all, but should be labeled "other".
Test Plan

Submitted a no-comments, inlines-only transaction and got a message with proper X-Phabricator-Mail-Tags header.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped