Page MenuHomePhabricator

Fix two edge case issues with Differential mail tags
ClosedPublic

Authored by epriestley on Jan 9 2014, 1:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 11 2024, 7:52 PM
Unknown Object (File)
Feb 4 2024, 5:48 AM
Unknown Object (File)
Jan 18 2024, 4:02 AM
Unknown Object (File)
Nov 30 2023, 4:50 PM
Unknown Object (File)
Nov 27 2023, 10:28 PM
Unknown Object (File)
Nov 23 2023, 1:14 PM
Unknown Object (File)
Nov 13 2023, 1:22 PM
Unknown Object (File)
Nov 8 2023, 3:18 AM
Subscribers

Details

Summary

Via Asana. The tags on Differential mail are wrong in two cases:

  • Transactions which submit inline comments but no comment text are not labeled as "comments", but should be.
  • Non-close, non-comment transactions are not labeled at all, but should be labeled "other".
Test Plan

Submitted a no-comments, inlines-only transaction and got a message with proper X-Phabricator-Mail-Tags header.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped