Fix two edge case issues with Differential mail tags
ClosedPublic
Actions

Authored by epriestley on Jan 9 2014, 1:53 AM.

Tags

None

Referenced Files

	F15491642: D7912.diff
	Sat, Apr 12, 5:48 AM

	F15454208: D7912.id17909.diff
	Sat, Mar 29, 4:59 PM

	F15428525: D7912.id.diff
	Sun, Mar 23, 8:56 PM

	F15419548: D7912.id.diff
	Fri, Mar 21, 6:57 AM

	F15404453: D7912.id17926.diff
	Tue, Mar 18, 7:47 AM

	F15318488: D7912.id17909.diff
	Mar 6 2025, 8:28 PM

	Unknown Object (File)
	Feb 23 2025, 5:16 AM

	Unknown Object (File)
	Feb 22 2025, 12:04 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP68de639470f0: Fix two edge case issues with Differential mail tags

Summary

Via Asana. The tags on Differential mail are wrong in two cases:

Transactions which submit inline comments but no comment text are not labeled as "comments", but should be.
Non-close, non-comment transactions are not labeled at all, but should be labeled "other".

Test Plan

Submitted a no-comments, inlines-only transaction and got a message with proper X-Phabricator-Mail-Tags header.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Jan 9 2014, 6:50 PM

Closed by commit rP68de639470f0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

mail/

DifferentialCommentMail.php

9 lines

Diff 17926

View Options

src/applications/differential/mail/DifferentialCommentMail.php

Fix two edge case issues with Differential mail tagsClosedPublicActions