Paths

Table of Contentst

Allow `PhutilTypeSpec` to work with classes and subclasses.
ClosedPublic
Actions

Authored by joshuaspence on Jan 7 2014, 5:21 AM.

Tags

None

Referenced Files

	F15178712: D7902.diff
	Wed, Feb 19, 10:55 AM

	Unknown Object (File)
	Fri, Jan 24, 5:29 AM

	Unknown Object (File)
	Wed, Jan 22, 12:25 PM

	Unknown Object (File)
	Jan 14 2025, 8:14 AM

	Unknown Object (File)
	Jan 13 2025, 4:54 AM

	Unknown Object (File)
	Dec 29 2024, 11:32 PM

	Unknown Object (File)
	Dec 17 2024, 5:33 AM

	Unknown Object (File)
	Dec 13 2024, 12:46 AM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4286: PhutilTypeSpec fails with classes

Commits

rPHU1aa6299fcdfb: Allow `PhutilTypeSpec` to work with classes and subclasses.

Summary

Fixes T4286.

Test Plan

arc unit -- src/parser/

Diff Detail

Branch

phutil_type_spec

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

I vaguely wonder if we should have some sort of marker for class names -- this means you can not name a class int, wild, etc., and then typecheck it, but those restrictions seem fairly reasonable.

Closed by commit rPHU1aa6299fcdfb (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

PhutilTypeSpec.php

31 lines

__tests__/

PhutilTypeSpecTestCase.php

39 lines

Diff 17885

View Options

src/parser/PhutilTypeSpec.php

View Options

src/parser/tests/PhutilTypeSpecTestCase.php

Allow `PhutilTypeSpec` to work with classes and subclasses.ClosedPublicActions