Paths

Table of Contentst

Allow `PhutilTypeSpec` to work with classes and subclasses.
ClosedPublic
Actions

Authored by joshuaspence on Jan 7 2014, 5:21 AM.

Tags

None

Referenced Files

	F15412632: D7902.id17885.diff
	Wed, Mar 19, 2:05 PM

	F15405439: D7902.id.diff
	Tue, Mar 18, 11:30 AM

	F15403575: D7902.id17886.diff
	Tue, Mar 18, 3:56 AM

	F15399285: D7902.diff
	Mon, Mar 17, 3:47 AM

	F15376868: D7902.id17886.diff
	Thu, Mar 13, 6:20 AM

	Unknown Object (File)
	Mon, Mar 3, 4:45 PM

	Unknown Object (File)
	Sun, Mar 2, 10:11 PM

	Unknown Object (File)
	Feb 21 2025, 4:42 AM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4286: PhutilTypeSpec fails with classes

Commits

rPHU1aa6299fcdfb: Allow `PhutilTypeSpec` to work with classes and subclasses.

Summary

Fixes T4286.

Test Plan

arc unit -- src/parser/

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

I vaguely wonder if we should have some sort of marker for class names -- this means you can not name a class int, wild, etc., and then typecheck it, but those restrictions seem fairly reasonable.

Closed by commit rPHU1aa6299fcdfb (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

PhutilTypeSpec.php

31 lines

__tests__/

PhutilTypeSpecTestCase.php

39 lines

Diff 17886

View Options

src/parser/PhutilTypeSpec.php

View Options

src/parser/tests/PhutilTypeSpecTestCase.php

Allow `PhutilTypeSpec` to work with classes and subclasses.ClosedPublicActions