Page MenuHomePhabricator

Split Herald rule creation across several steps
ClosedPublic

Authored by epriestley on Dec 27 2013, 6:00 PM.
Tags
None
Referenced Files
F15456866: D7845.id17754.diff
Sun, Mar 30, 12:42 PM
F15448731: D7845.diff
Fri, Mar 28, 6:38 AM
F15438628: D7845.id17754.diff
Wed, Mar 26, 2:06 AM
F15333175: D7845.id.diff
Mar 8 2025, 12:29 AM
Unknown Object (File)
Mar 3 2025, 10:02 PM
Unknown Object (File)
Feb 9 2025, 10:59 AM
Unknown Object (File)
Feb 9 2025, 10:59 AM
Unknown Object (File)
Feb 9 2025, 10:59 AM
Subscribers

Details

Summary

Ref T4264. Currently, you choose a rule's content type (revision, commit, hook) and rule type (global, personal) on the same screen.

  • I want to make some rule types unavailable for some content types (e.g., personal hooks make little sense).
  • I want to make content type selection use a radio control instead of a dropdown, so it can explain what the content types do in more detail.
  • For new "object" hooks, I want to add a third step where you'll pick an object to bind to.

Split rule creation out into two steps. I think this won't get complicated enough for PHUIPagedFormView, but maybe I'll swap it in if this gets messier than I think.

Test Plan

Created some Herald rules, used back/cancel/etc.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped