Page MenuHomePhabricator

Split Herald rule creation across several steps
ClosedPublic

Authored by epriestley on Dec 27 2013, 6:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 26 2024, 2:43 AM
Unknown Object (File)
Jan 11 2024, 11:13 AM
Unknown Object (File)
Dec 25 2023, 5:42 PM
Unknown Object (File)
Dec 24 2023, 12:26 AM
Unknown Object (File)
Dec 22 2023, 6:52 PM
Unknown Object (File)
Dec 20 2023, 10:05 AM
Unknown Object (File)
Nov 29 2023, 2:56 PM
Unknown Object (File)
Nov 25 2023, 5:07 AM
Subscribers

Details

Summary

Ref T4264. Currently, you choose a rule's content type (revision, commit, hook) and rule type (global, personal) on the same screen.

  • I want to make some rule types unavailable for some content types (e.g., personal hooks make little sense).
  • I want to make content type selection use a radio control instead of a dropdown, so it can explain what the content types do in more detail.
  • For new "object" hooks, I want to add a third step where you'll pick an object to bind to.

Split rule creation out into two steps. I think this won't get complicated enough for PHUIPagedFormView, but maybe I'll swap it in if this gets messier than I think.

Test Plan

Created some Herald rules, used back/cancel/etc.

Diff Detail

Branch
herald1
Lint
Lint Passed
Unit
No Test Coverage