Page MenuHomePhabricator

Split Herald rule creation across several steps
ClosedPublic

Authored by epriestley on Dec 27 2013, 6:00 PM.
Tags
None
Referenced Files
F18854378: D7845.id.diff
Oct 31 2025, 11:47 PM
F18844408: D7845.diff
Oct 29 2025, 5:11 AM
F18808719: D7845.id.diff
Oct 19 2025, 8:09 AM
F18630726: D7845.diff
Sep 16 2025, 12:46 PM
F18110922: D7845.id17754.diff
Aug 12 2025, 2:16 AM
F17942738: D7845.diff
Jul 31 2025, 7:05 AM
F17942736: D7845.id.diff
Jul 31 2025, 7:05 AM
F17937137: D7845.id.diff
Jul 31 2025, 12:53 AM
Subscribers

Details

Summary

Ref T4264. Currently, you choose a rule's content type (revision, commit, hook) and rule type (global, personal) on the same screen.

  • I want to make some rule types unavailable for some content types (e.g., personal hooks make little sense).
  • I want to make content type selection use a radio control instead of a dropdown, so it can explain what the content types do in more detail.
  • For new "object" hooks, I want to add a third step where you'll pick an object to bind to.

Split rule creation out into two steps. I think this won't get complicated enough for PHUIPagedFormView, but maybe I'll swap it in if this gets messier than I think.

Test Plan

Created some Herald rules, used back/cancel/etc.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped