Page MenuHomePhabricator

Split Herald rule creation across several steps
ClosedPublic

Authored by epriestley on Dec 27 2013, 6:00 PM.
Tags
None
Referenced Files
F17823208: D7845.id.diff
Sat, Jul 26, 4:25 AM
F17812315: D7845.id17754.diff
Fri, Jul 25, 7:20 PM
F17758614: D7845.diff
Tue, Jul 22, 5:31 PM
F17743695: D7845.id17754.diff
Mon, Jul 21, 2:29 PM
Unknown Object (File)
Jun 5 2025, 1:04 PM
Unknown Object (File)
Jun 1 2025, 3:45 PM
Unknown Object (File)
May 29 2025, 11:32 PM
Unknown Object (File)
May 28 2025, 8:17 AM
Subscribers

Details

Summary

Ref T4264. Currently, you choose a rule's content type (revision, commit, hook) and rule type (global, personal) on the same screen.

  • I want to make some rule types unavailable for some content types (e.g., personal hooks make little sense).
  • I want to make content type selection use a radio control instead of a dropdown, so it can explain what the content types do in more detail.
  • For new "object" hooks, I want to add a third step where you'll pick an object to bind to.

Split rule creation out into two steps. I think this won't get complicated enough for PHUIPagedFormView, but maybe I'll swap it in if this gets messier than I think.

Test Plan

Created some Herald rules, used back/cancel/etc.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped