Page MenuHomePhabricator

Implment ApplicationTransaction grouping rules
ClosedPublic

Authored by epriestley on Dec 27 2013, 3:51 AM.
Tags
None
Referenced Files
F14067586: D7843.diff
Tue, Nov 19, 3:45 PM
F14053202: D7843.id17740.diff
Fri, Nov 15, 1:03 PM
F14053201: D7843.id17738.diff
Fri, Nov 15, 1:03 PM
F14018446: D7843.diff
Tue, Nov 5, 12:21 PM
F13980662: D7843.id17740.diff
Oct 19 2024, 11:52 AM
F13956077: D7843.diff
Oct 14 2024, 4:08 AM
Unknown Object (File)
Oct 9 2024, 3:16 PM
Unknown Object (File)
Oct 9 2024, 3:16 PM
Subscribers

Details

Summary

Ref T4266. This implements rules similar to the old rules. With D7842, maybe this is reasonable? I think it's not like grotesquely bad, at least.

Test Plan

See screenshot.

Diff Detail

Branch
grouprules
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

That screenshot is probably on the heavy end (I have a pile of custom fields on my local install) but seems pretty reasonable to me, at least as a first step.

epriestley updated this revision to Unknown Object (????).Dec 27 2013, 4:00 AM
  • Fix a minor issue with the "Edit" / "Editable" links.

Particularly, this:

  • groups transactions based on a similar heuristic to the old one (group if the same user took several actions in a short period of time, from the same source, without posting multiple comments and with no intervening activity by other users);
  • sorts transactions within a group so more important transactions appear first;
  • transactions are then sorted by icon vs no icon, so it's "all transactions with an icon, in descending priority order" followed by those without, in descending priority order;
  • the first transaction dictates the color (this should be the most important transaction with an icon);
  • if a transaction is "comment", and there are other transactions in the group, we hide the "commented on" text and icon.

Can we just use the edit pencil as default action taken (since, likely, you editing something).

epriestley updated this revision to Unknown Object (????).Dec 27 2013, 4:20 AM
  • Use 'edit' as default icon.

This one's maybe a touch funky with that, but this is a relatively extreme example.

{F93540}

I can clean that up after, Timeline needs some love in general.

Yeah -- I think that's a worst-case scenario, and it's really not bad.