Reduce derps in timeline event group rendering
ClosedPublic
Actions

Authored by epriestley on Dec 27 2013, 3:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 18, 12:03 AM

	Unknown Object (File)
	Tue, Dec 24, 12:02 PM

	Unknown Object (File)
	Tue, Dec 24, 2:34 AM

	Unknown Object (File)
	Dec 15 2024, 12:10 PM

	Unknown Object (File)
	Dec 15 2024, 12:10 PM

	Unknown Object (File)
	Dec 15 2024, 12:10 PM

	Unknown Object (File)
	Dec 15 2024, 12:10 PM

	Unknown Object (File)
	Dec 11 2024, 1:52 PM

View All Files

Subscribers

aran

Details

Reviewers

wotte
chad

Maniphest Tasks

T4266: Clean up UI on grouped Timeline Events

Commits

Restricted Diffusion Commit
rPdf053abd6ec1: Reduce derps in timeline event group rendering

Summary

Ref T4266. This possibly moves us towards getting reasonable timeline grouping:

Always sort icon stories to the top.
Render one timestamp for the whole group, using the earliest tranaction date.
Move any "Edit", "Edited", or "Preview" links to the top.
Rendering just one timestamp implicitly fixes the JS issues.
For stories without an icon, indent them if any member of the group has an icon.

Test Plan

See screenshots.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Old:

{F93518}

New:

{F93515}

This doesn't totally de-derp it, but seems like a step forward on all counts.

Are there things that don't have an icon that should?

Not sure -- let me put this in the actual ApplicationTransactions and we can see how reasonable or unreasonable it looks.

Closed by commit rPdf053abd6ec1 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

view/

layout/

PhabricatorTimelineEventView.php

123 lines

Diff 17737

View Options

src/view/layout/PhabricatorTimelineEventView.php

Reduce derps in timeline event group renderingClosedPublicActions