Page MenuHomePhabricator

Reduce derps in timeline event group rendering
ClosedPublic

Authored by epriestley on Dec 27 2013, 3:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 12, 12:45 AM
Unknown Object (File)
Tue, Mar 12, 12:44 AM
Unknown Object (File)
Mon, Mar 11, 8:04 PM
Unknown Object (File)
Mon, Mar 11, 8:04 PM
Unknown Object (File)
Sun, Mar 10, 6:00 AM
Unknown Object (File)
Wed, Feb 28, 10:50 AM
Unknown Object (File)
Feb 6 2024, 11:10 AM
Unknown Object (File)
Dec 27 2023, 1:53 PM
Subscribers

Details

Summary

Ref T4266. This possibly moves us towards getting reasonable timeline grouping:

  • Always sort icon stories to the top.
  • Render one timestamp for the whole group, using the earliest tranaction date.
  • Move any "Edit", "Edited", or "Preview" links to the top.
  • Rendering just one timestamp implicitly fixes the JS issues.
  • For stories without an icon, indent them if any member of the group has an icon.
Test Plan

See screenshots.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Old:

{F93518}

New:

{F93515}

This doesn't totally de-derp it, but seems like a step forward on all counts.

Are there things that don't have an icon that should?

Not sure -- let me put this in the actual ApplicationTransactions and we can see how reasonable or unreasonable it looks.