Page MenuHomePhabricator

Modernize Drydock CLI management of task execution
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:03 PM.
Tags
None
Referenced Files
F14898040: D7835.id17747.diff
Sun, Feb 9, 10:58 AM
F14898039: D7835.id17728.diff
Sun, Feb 9, 10:58 AM
F14898038: D7835.id.diff
Sun, Feb 9, 10:58 AM
F14898037: D7835.diff
Sun, Feb 9, 10:57 AM
Unknown Object (File)
Sat, Feb 8, 1:41 AM
Unknown Object (File)
Fri, Feb 7, 9:05 PM
Unknown Object (File)
Mon, Feb 3, 8:48 AM
Unknown Object (File)
Mon, Feb 3, 8:48 AM
Subscribers

Details

Summary

Ref T2015. Currently, Drydock has a wait-for-lease workflow which is invoked in the background by the lease workflow.

The goal of this mechanism is to allow bin/drydock lease to print out logs as the lease is acquired. However, this predates the runAllTasksInProcess flags, and they provide a simpler and more robust way (potentially with --trace and PhutilConsole) to do synchronous execution and debug logging.

Simplify this whole mechanism: just run everything in-process in bin/drydock lease, and do logging via --trace. We could thread a PhutilConsole through things too, but this seems good enough for now.

Also various cleanup/etc.

Test Plan

Ran bin/drydock lease. Ran bin/harbormaster build X --plan Y, for Y being a Drydock-dependent build plan.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped