Page MenuHomePhabricator

Modernize Drydock CLI management of task execution
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:03 PM.
Tags
None
Referenced Files
F19653507: D7835.id17747.diff
Fri, Feb 6, 3:02 PM
F19651140: D7835.diff
Fri, Feb 6, 10:54 AM
F19532097: D7835.id.diff
Jan 20 2026, 8:55 AM
F19528421: D7835.id.diff
Jan 19 2026, 8:57 AM
F19510358: D7835.diff
Jan 11 2026, 8:13 AM
F18838053: D7835.diff
Oct 27 2025, 8:56 AM
F18821451: D7835.id.diff
Oct 22 2025, 11:15 PM
F18817009: D7835.diff
Oct 21 2025, 11:24 AM
Subscribers

Details

Summary

Ref T2015. Currently, Drydock has a wait-for-lease workflow which is invoked in the background by the lease workflow.

The goal of this mechanism is to allow bin/drydock lease to print out logs as the lease is acquired. However, this predates the runAllTasksInProcess flags, and they provide a simpler and more robust way (potentially with --trace and PhutilConsole) to do synchronous execution and debug logging.

Simplify this whole mechanism: just run everything in-process in bin/drydock lease, and do logging via --trace. We could thread a PhutilConsole through things too, but this seems good enough for now.

Also various cleanup/etc.

Test Plan

Ran bin/drydock lease. Ran bin/harbormaster build X --plan Y, for Y being a Drydock-dependent build plan.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped