Page MenuHomePhabricator

Modernize Drydock CLI management of task execution
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:03 PM.
Tags
None
Referenced Files
F18616409: D7835.diff
Sun, Sep 14, 5:26 PM
F17851274: D7835.id.diff
Jul 27 2025, 11:04 AM
F17788104: D7835.id.diff
Jul 24 2025, 5:21 PM
F17755616: D7835.diff
Jul 22 2025, 12:46 PM
F17703035: D7835.id17728.diff
Jul 16 2025, 12:21 AM
Unknown Object (File)
Jul 3 2025, 10:42 AM
Unknown Object (File)
Jul 1 2025, 7:04 PM
Unknown Object (File)
Jun 27 2025, 12:19 PM
Subscribers

Details

Summary

Ref T2015. Currently, Drydock has a wait-for-lease workflow which is invoked in the background by the lease workflow.

The goal of this mechanism is to allow bin/drydock lease to print out logs as the lease is acquired. However, this predates the runAllTasksInProcess flags, and they provide a simpler and more robust way (potentially with --trace and PhutilConsole) to do synchronous execution and debug logging.

Simplify this whole mechanism: just run everything in-process in bin/drydock lease, and do logging via --trace. We could thread a PhutilConsole through things too, but this seems good enough for now.

Also various cleanup/etc.

Test Plan

Ran bin/drydock lease. Ran bin/harbormaster build X --plan Y, for Y being a Drydock-dependent build plan.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped