Page MenuHomePhabricator
Differential D7791

Support "changed filename" and "file content" fields for commit content Herald rules
ClosedPublic
Actions

Authored by epriestley on Dec 18 2013, 9:21 PM.
Tags
None
Referenced Files
F15512409: D7791.id.diff
Thu, Apr 17, 10:26 AM
F15508935: D7791.diff
Wed, Apr 16, 7:33 AM
F15489383: D7791.diff
Fri, Apr 11, 8:31 AM
F15470437: D7791.diff
Fri, Apr 4, 10:12 PM
F15416659: D7791.id.diff
Thu, Mar 20, 12:50 PM
F15395911: D7791.id17626.diff
Mar 16 2025, 10:41 AM
F15395784: D7791.id17628.diff
Mar 16 2025, 9:48 AM
F15395780: D7791.id17624.diff
Mar 16 2025, 9:46 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4195: Implement pre-commit Herald rules
Commits
Restricted Diffusion Commit
rP5f4df0f3e394: Support "changed filename" and "file content" fields for commit content Herald…
Summary

Ref T4195. Adds support for diff content rules.

Test Plan

Pushed SVN and Git changes through, saw them generate reasonable transcripts. Mercurial still isn't hooked up to this phase.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 18 2013, 10:14 PM
btrahan added inline comments.
src/applications/diffusion/engine/DiffusionCommitHookEngine.php
906

this is un-used

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
175

does getFileName include path? (wondering if its always unique?)

epriestley added inline comments.Dec 18 2013, 10:15 PM
src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
175

Yeah, it's the full path from the repository root.

epriestley updated this revision to Unknown Object (????).Dec 18 2013, 10:16 PM
  • Remove unused variable.
epriestley closed this revision.Dec 18 2013, 10:19 PM

Closed by commit rP5f4df0f3e394 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
39 lines
herald/
64 lines
herald/
storage/
2 lines

Diff 17628

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
Phabricator · Built by Phacility