Page MenuHomePhabricator
Differential D7791

Support "changed filename" and "file content" fields for commit content Herald rules
ClosedPublic
Actions

Authored by epriestley on Dec 18 2013, 9:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 10:01 AM
Unknown Object (File)
Tue, Dec 10, 1:22 PM
Unknown Object (File)
Fri, Dec 6, 5:35 AM
Unknown Object (File)
Mon, Dec 2, 8:25 PM
Unknown Object (File)
Tue, Nov 26, 5:59 PM
Unknown Object (File)
Fri, Nov 22, 12:45 AM
Unknown Object (File)
Nov 17 2024, 11:01 PM
Unknown Object (File)
Nov 14 2024, 5:39 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4195: Implement pre-commit Herald rules
Commits
Restricted Diffusion Commit
rP5f4df0f3e394: Support "changed filename" and "file content" fields for commit content Herald…
Summary

Ref T4195. Adds support for diff content rules.

Test Plan

Pushed SVN and Git changes through, saw them generate reasonable transcripts. Mercurial still isn't hooked up to this phase.

Diff Detail

Branch
hcommit2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/engine/DiffusionCommitHookEngine.php:906XHP16TODO Comment
Unit
Tests Passed

Event Timeline

btrahan accepted this revision.Dec 18 2013, 10:14 PM
btrahan added inline comments.
src/applications/diffusion/engine/DiffusionCommitHookEngine.php
906

this is un-used

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
175

does getFileName include path? (wondering if its always unique?)

epriestley added inline comments.Dec 18 2013, 10:15 PM
src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
175

Yeah, it's the full path from the repository root.

epriestley updated this revision to Unknown Object (????).Dec 18 2013, 10:16 PM
  • Remove unused variable.
epriestley closed this revision.Dec 18 2013, 10:19 PM

Closed by commit rP5f4df0f3e394 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
39 lines
herald/
64 lines
herald/
storage/
2 lines

Diff 17626

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
Phabricator · Built by Phacility