Page MenuHomePhabricator

Support "changed filename" and "file content" fields for commit content Herald rules
ClosedPublic

Authored by epriestley on Dec 18 2013, 9:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 5:25 AM
Unknown Object (File)
Feb 9 2024, 9:14 PM
Unknown Object (File)
Feb 6 2024, 7:28 PM
Unknown Object (File)
Dec 3 2023, 6:05 AM
Unknown Object (File)
Dec 1 2023, 1:48 PM
Unknown Object (File)
Nov 23 2023, 12:47 PM
Unknown Object (File)
Nov 18 2023, 8:39 AM
Unknown Object (File)
Nov 14 2023, 8:49 PM
Subscribers

Details

Summary

Ref T4195. Adds support for diff content rules.

Test Plan

Pushed SVN and Git changes through, saw them generate reasonable transcripts. Mercurial still isn't hooked up to this phase.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/diffusion/engine/DiffusionCommitHookEngine.php
906

this is un-used

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
175

does getFileName include path? (wondering if its always unique?)

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php
175

Yeah, it's the full path from the repository root.

epriestley updated this revision to Unknown Object (????).Dec 18 2013, 10:16 PM
  • Remove unused variable.