Page MenuHomePhabricator

Use PhutilRope for Channel write buffers and make write buffer details public
ClosedPublic

Authored by epriestley on Dec 16 2013, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 4 2026, 12:01 PM
Unknown Object (File)
Mar 1 2026, 4:09 PM
Unknown Object (File)
Feb 9 2026, 7:36 PM
Unknown Object (File)
Jan 17 2026, 9:19 PM
Unknown Object (File)
Jan 9 2026, 3:13 AM
Unknown Object (File)
Jan 9 2026, 3:13 AM
Unknown Object (File)
Dec 24 2025, 10:19 PM
Unknown Object (File)
Dec 24 2025, 7:58 AM
Subscribers

Details

Summary

Ref T4241. Two changes:

  • Use PhutilRope instead of plain string for the Channel write buffers. This makes it more consistent, and should improve performance in some cases.
  • Expose information about buffer sizes as public. We need this in a future diff to be able to throttle reads when we're blocked on writes, since we have to be able to test if a write channel is blocked or not.
Test Plan

Ran arc unit. Ran git operations over SSH.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped