Page MenuHomePhabricator

Use PhutilRope for Channel write buffers and make write buffer details public
ClosedPublic

Authored by epriestley on Dec 16 2013, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 5:12 AM
Unknown Object (File)
Fri, May 3, 2:37 AM
Unknown Object (File)
Wed, May 1, 6:45 PM
Unknown Object (File)
Mon, Apr 29, 2:06 PM
Unknown Object (File)
Sat, Apr 27, 2:06 AM
Unknown Object (File)
Wed, Apr 24, 9:56 PM
Unknown Object (File)
Mon, Apr 22, 1:12 AM
Unknown Object (File)
Sun, Apr 21, 4:21 PM
Subscribers

Details

Summary

Ref T4241. Two changes:

  • Use PhutilRope instead of plain string for the Channel write buffers. This makes it more consistent, and should improve performance in some cases.
  • Expose information about buffer sizes as public. We need this in a future diff to be able to throttle reads when we're blocked on writes, since we have to be able to test if a write channel is blocked or not.
Test Plan

Ran arc unit. Ran git operations over SSH.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped