Page MenuHomePhabricator

Restructure HookEngine to use PushLog records for all operations
ClosedPublic

Authored by epriestley on Dec 12 2013, 8:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 6, 2:43 AM
Unknown Object (File)
Wed, May 1, 8:12 PM
Unknown Object (File)
Wed, May 1, 8:02 AM
Unknown Object (File)
Sun, Apr 28, 10:13 AM
Unknown Object (File)
Sat, Apr 27, 4:55 PM
Unknown Object (File)
Sat, Apr 27, 4:55 PM
Unknown Object (File)
Sat, Apr 27, 4:55 PM
Unknown Object (File)
Sat, Apr 27, 4:55 PM
Subscribers

Details

Summary

Ref T4195. This pulls the central logic of HookEngine up one level and makes all the git stuff genrate PushLogs.

In future diffs, everything will generate PushLogs and we can hand those off to Herald.

Test Plan

Pushed a pile of valid/invalid stuff:

{F89256}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/diffusion/engine/DiffusionCommitHookEngine.php
445–447

smart