Ref T4195. This pulls the central logic of HookEngine up one level and makes all the git stuff genrate PushLogs.
In future diffs, everything will generate PushLogs and we can hand those off to Herald.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T4195: Implement pre-commit Herald rules
- Commits
- Restricted Diffusion Commit
rP2725586bafa0: Restructure HookEngine to use PushLog records for all operations
Pushed a pile of valid/invalid stuff:
{F89256}
Diff Detail
Diff Detail
- Branch
- morehooks
- Lint
Lint Passed Severity Location Code Message Advice src/applications/diffusion/controller/DiffusionPushLogListController.php:87 XHP16 TODO Comment Advice src/applications/diffusion/engine/DiffusionCommitHookEngine.php:123 XHP16 TODO Comment Advice src/applications/diffusion/engine/DiffusionCommitHookEngine.php:128 XHP16 TODO Comment Advice src/applications/diffusion/engine/DiffusionCommitHookEngine.php:129 XHP16 TODO Comment Advice src/applications/diffusion/engine/DiffusionCommitHookEngine.php:417 XHP16 TODO Comment Advice src/applications/diffusion/engine/DiffusionCommitHookEngine.php:422 XHP16 TODO Comment Advice src/applications/diffusion/engine/DiffusionCommitHookEngine.php:431 XHP16 TODO Comment Advice src/applications/diffusion/engine/DiffusionCommitHookEngine.php:436 XHP16 TODO Comment - Unit
Tests Passed