Page MenuHomePhabricator

Restructure HookEngine to use PushLog records for all operations
ClosedPublic

Authored by epriestley on Dec 12 2013, 8:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 14 2026, 5:25 AM
Unknown Object (File)
Feb 20 2026, 4:47 PM
Unknown Object (File)
Jan 29 2026, 12:25 PM
Unknown Object (File)
Jan 12 2026, 9:37 AM
Unknown Object (File)
Dec 11 2025, 3:46 PM
Unknown Object (File)
Dec 2 2025, 1:28 AM
Unknown Object (File)
Dec 1 2025, 12:09 PM
Unknown Object (File)
Nov 26 2025, 4:42 AM
Subscribers

Details

Summary

Ref T4195. This pulls the central logic of HookEngine up one level and makes all the git stuff genrate PushLogs.

In future diffs, everything will generate PushLogs and we can hand those off to Herald.

Test Plan

Pushed a pile of valid/invalid stuff:

{F89256}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/diffusion/engine/DiffusionCommitHookEngine.php
445–447

smart