Page MenuHomePhabricator

Restructure HookEngine to use PushLog records for all operations
ClosedPublic

Authored by epriestley on Dec 12 2013, 8:24 PM.
Tags
None
Referenced Files
F15441527: D7761.diff
Wed, Mar 26, 6:37 PM
F15427554: D7761.id.diff
Sun, Mar 23, 2:54 PM
F15416122: D7761.id17596.diff
Thu, Mar 20, 9:22 AM
F15415268: D7761.id17596.diff
Thu, Mar 20, 5:07 AM
F15413917: D7761.id17596.diff
Wed, Mar 19, 9:58 PM
F15400645: D7761.id17556.diff
Mon, Mar 17, 1:08 PM
F15396680: D7761.diff
Sun, Mar 16, 3:48 PM
F15393529: D7761.diff
Sat, Mar 15, 9:14 PM
Subscribers

Details

Summary

Ref T4195. This pulls the central logic of HookEngine up one level and makes all the git stuff genrate PushLogs.

In future diffs, everything will generate PushLogs and we can hand those off to Herald.

Test Plan

Pushed a pile of valid/invalid stuff:

{F89256}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/diffusion/engine/DiffusionCommitHookEngine.php
445–447

smart