Page MenuHomePhabricator

Fix two issues with creating Conpherence threads via mail on some configurations
ClosedPublic

Authored by epriestley on Dec 12 2013, 6:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 24, 11:19 AM
Unknown Object (File)
Mon, Feb 17, 2:56 AM
Unknown Object (File)
Mon, Feb 17, 1:44 AM
Unknown Object (File)
Sun, Feb 9, 10:50 AM
Unknown Object (File)
Sun, Feb 9, 10:50 AM
Unknown Object (File)
Sun, Feb 9, 10:50 AM
Unknown Object (File)
Sun, Feb 9, 10:50 AM
Unknown Object (File)
Jan 28 2025, 6:06 AM
Subscribers

Details

Summary

Ref T4107. Two issues:

  • With strict MySQL settings, we try to insert null into the non-nullable messageCount field. Add an initializeNew... method.
  • If we don't create a new conpherence (for example, because the message body is empty), we fatal on getPHID() right now.

Also, make this stuff a little easier to test.

Test Plan

Used mail_handler.php to receive empty conpherence mail, and new-thread conpherence mail.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped