Page MenuHomePhabricator

Fix two issues with creating Conpherence threads via mail on some configurations
ClosedPublic

Authored by epriestley on Dec 12 2013, 6:14 PM.
Tags
None
Referenced Files
F22730547: D7760.id.diff
Sun, Oct 4, 6:03 AM
F22595882: D7760.diff
Mon, Sep 28, 11:51 AM
Unknown Object (File)
Aug 10 2026, 9:05 PM
Unknown Object (File)
Aug 10 2026, 6:16 PM
Unknown Object (File)
Aug 9 2026, 3:02 PM
Unknown Object (File)
Jul 3 2026, 12:20 AM
Unknown Object (File)
Mar 21 2026, 3:50 AM
Unknown Object (File)
Mar 19 2026, 2:35 AM
Subscribers

Details

Summary

Ref T4107. Two issues:

  • With strict MySQL settings, we try to insert null into the non-nullable messageCount field. Add an initializeNew... method.
  • If we don't create a new conpherence (for example, because the message body is empty), we fatal on getPHID() right now.

Also, make this stuff a little easier to test.

Test Plan

Used mail_handler.php to receive empty conpherence mail, and new-thread conpherence mail.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped