Page MenuHomePhabricator

Fix two issues with creating Conpherence threads via mail on some configurations
ClosedPublic

Authored by epriestley on Dec 12 2013, 6:14 PM.
Tags
None
Referenced Files
F18419325: D7760.id.diff
Sat, Aug 30, 2:20 PM
F18395500: D7760.diff
Fri, Aug 29, 11:13 AM
F18086190: D7760.id17555.diff
Aug 5 2025, 7:53 PM
F17871473: D7760.id.diff
Jul 28 2025, 3:57 PM
F17852849: D7760.diff
Jul 27 2025, 1:07 PM
Unknown Object (File)
Jul 2 2025, 12:45 AM
Unknown Object (File)
May 8 2025, 12:58 AM
Unknown Object (File)
May 5 2025, 9:13 PM
Subscribers

Details

Summary

Ref T4107. Two issues:

  • With strict MySQL settings, we try to insert null into the non-nullable messageCount field. Add an initializeNew... method.
  • If we don't create a new conpherence (for example, because the message body is empty), we fatal on getPHID() right now.

Also, make this stuff a little easier to test.

Test Plan

Used mail_handler.php to receive empty conpherence mail, and new-thread conpherence mail.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped