Page MenuHomePhabricator

Fix two issues with creating Conpherence threads via mail on some configurations
ClosedPublic

Authored by epriestley on Dec 12 2013, 6:14 PM.
Tags
None
Referenced Files
F14021109: D7760.diff
Wed, Nov 6, 5:38 AM
F14007045: D7760.diff
Mon, Oct 28, 10:51 PM
F13971404: D7760.diff
Thu, Oct 17, 1:11 PM
Unknown Object (File)
Sun, Oct 13, 11:49 AM
Unknown Object (File)
Oct 10 2024, 1:03 PM
Unknown Object (File)
Oct 8 2024, 10:53 PM
Unknown Object (File)
Oct 5 2024, 4:27 PM
Unknown Object (File)
Oct 5 2024, 4:27 PM
Subscribers

Details

Summary

Ref T4107. Two issues:

  • With strict MySQL settings, we try to insert null into the non-nullable messageCount field. Add an initializeNew... method.
  • If we don't create a new conpherence (for example, because the message body is empty), we fatal on getPHID() right now.

Also, make this stuff a little easier to test.

Test Plan

Used mail_handler.php to receive empty conpherence mail, and new-thread conpherence mail.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped