Page MenuHomePhabricator

Fix two issues with creating Conpherence threads via mail on some configurations
ClosedPublic

Authored by epriestley on Dec 12 2013, 6:14 PM.
Tags
None
Referenced Files
F15458053: D7760.diff
Sun, Mar 30, 8:31 PM
F15449287: D7760.diff
Fri, Mar 28, 9:16 AM
F15433432: D7760.diff
Mon, Mar 24, 11:08 PM
F15426288: D7760.id.diff
Sun, Mar 23, 7:57 AM
F15413533: D7760.id17554.diff
Wed, Mar 19, 7:30 PM
F15390629: D7760.id17554.diff
Sat, Mar 15, 6:23 AM
F15389796: D7760.id.diff
Sat, Mar 15, 5:39 AM
F15333321: D7760.id.diff
Sat, Mar 8, 1:45 AM
Subscribers

Details

Summary

Ref T4107. Two issues:

  • With strict MySQL settings, we try to insert null into the non-nullable messageCount field. Add an initializeNew... method.
  • If we don't create a new conpherence (for example, because the message body is empty), we fatal on getPHID() right now.

Also, make this stuff a little easier to test.

Test Plan

Used mail_handler.php to receive empty conpherence mail, and new-thread conpherence mail.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped