Page MenuHomePhabricator

Fix two issues with creating Conpherence threads via mail on some configurations
ClosedPublic

Authored by epriestley on Dec 12 2013, 6:14 PM.
Tags
None
Referenced Files
F14415942: D7760.diff
Tue, Dec 24, 7:40 PM
Unknown Object (File)
Sun, Dec 22, 12:08 AM
Unknown Object (File)
Fri, Dec 13, 11:31 AM
Unknown Object (File)
Mon, Dec 9, 7:43 PM
Unknown Object (File)
Mon, Dec 9, 10:58 AM
Unknown Object (File)
Wed, Dec 4, 11:31 PM
Unknown Object (File)
Sat, Nov 30, 8:59 PM
Unknown Object (File)
Tue, Nov 26, 9:35 PM
Subscribers

Details

Summary

Ref T4107. Two issues:

  • With strict MySQL settings, we try to insert null into the non-nullable messageCount field. Add an initializeNew... method.
  • If we don't create a new conpherence (for example, because the message body is empty), we fatal on getPHID() right now.

Also, make this stuff a little easier to test.

Test Plan

Used mail_handler.php to receive empty conpherence mail, and new-thread conpherence mail.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped