Page MenuHomePhabricator

Fix two issues with creating Conpherence threads via mail on some configurations
ClosedPublic

Authored by epriestley on Dec 12 2013, 6:14 PM.
Tags
None
Referenced Files
F19083907: D7760.id.diff
Tue, Dec 2, 1:59 PM
F19075898: D7760.diff
Mon, Dec 1, 11:12 AM
F18853028: D7760.id.diff
Oct 31 2025, 1:50 PM
F18849637: D7760.diff
Oct 30 2025, 11:07 AM
F18839456: D7760.id.diff
Oct 27 2025, 4:34 PM
F18775193: D7760.id17555.diff
Oct 10 2025, 6:14 PM
F18735697: D7760.id17554.diff
Oct 1 2025, 3:05 AM
F18715800: D7760.diff
Sep 29 2025, 10:45 AM
Subscribers

Details

Summary

Ref T4107. Two issues:

  • With strict MySQL settings, we try to insert null into the non-nullable messageCount field. Add an initializeNew... method.
  • If we don't create a new conpherence (for example, because the message body is empty), we fatal on getPHID() right now.

Also, make this stuff a little easier to test.

Test Plan

Used mail_handler.php to receive empty conpherence mail, and new-thread conpherence mail.

Diff Detail

Branch
conmail
Lint
Lint Passed
Unit
Tests Passed