Implement "Revert to Version" functionality in Phragment
ClosedPublic
Actions

Authored by hach-que on Dec 7 2013, 7:12 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4205: Implement Phragment

Commits

Restricted Diffusion Commit
rPe1657877251b: Implement "Revert to Version" functionality in Phragment

Summary

This functionality allows users to revert a fragment to a previous version from the history page.

Reverting a version actually creates a new version pointing at the same file as the version being "reverted" to. In this sense it acts pretty much like Git and other distributed VCS where once you have published a commit the only way to undo your changes is to create a new commit that reverts those changes.

Test Plan

Reverted a fragment to a version before it was deleted, then reverted it to when it was deleted and saw the new versions have the correct file PHIDs (including null for the deletion).

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Rebase on master

epriestley accepted this revision.Dec 8 2013, 3:10 PM

epriestley added inline comments.

src/applications/phragment/controller/PhragmentRevertController.php
20–21	Here (and probably elsewhere) we should be requireCapabilities()'ing the CAN_EDIT capability.
56	Ideally, we should `setURI()` here, and point it at the original detail/edit page. If a user right-clicks a workflow link or has Javascript disabled, they'll arrive on this page and we'll render a standalone dialog. The uri-less redirect will then reload the page. This works fine as-is in normal circumstances, but breaks down in those special cases. If generating the original URI is a pain (e.g., it relies on specific parameters to a search query), shipping the user to any reasonable page with `AphorntReloadResponse` is fine: it will still do the right thing for JS, and do something reasonable for no-JS.