Page MenuHomePhabricator

Render deleted files in Phragment as disabled
ClosedPublic

Authored by hach-que on Dec 7 2013, 6:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 6:14 PM
Unknown Object (File)
Sat, Nov 16, 4:45 AM
Unknown Object (File)
Mon, Nov 11, 8:00 PM
Unknown Object (File)
Fri, Nov 8, 12:55 AM
Unknown Object (File)
Oct 23 2024, 6:48 AM
Unknown Object (File)
Oct 22 2024, 12:02 PM
Unknown Object (File)
Oct 14 2024, 2:25 PM
Unknown Object (File)
Oct 5 2024, 3:57 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4205: Implement Phragment
Commits
Restricted Diffusion Commit
rPdabc7ea28dec: Render deleted files in Phragment as disabled
Summary

This updates Phragment so that fragments that are currently considered deleted have a disabled status and have an additional attribute 'Deleted'. It also places this effect on versions (in the history controller) that actually involve deleting the file.

Test Plan

Viewed deleted fragments and versions.

Diff Detail

Branch
render-deleted-files
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Consider adding $fragment->isDeleted(), since I'd guess we'll need to represent this with slightly more finesse eventually (to be able to represente a file being converted into a directory and back in history).

hach-que updated this revision to Unknown Object (????).Dec 8 2013, 8:52 PM

Added isDeleted()