Page MenuHomePhabricator

Render deleted files in Phragment as disabled
ClosedPublic

Authored by hach-que on Dec 7 2013, 6:40 AM.
Tags
None
Referenced Files
F15558936: D7737.diff
Tue, Apr 29, 6:09 AM
F15511027: D7737.id17501.diff
Wed, Apr 16, 11:35 PM
F15507360: D7737.id17502.diff
Tue, Apr 15, 7:01 PM
F15488986: D7737.id17501.diff
Fri, Apr 11, 4:55 AM
F15458165: D7737.id17502.diff
Sun, Mar 30, 9:24 PM
F15454566: D7737.id.diff
Mar 29 2025, 7:06 PM
F15449372: D7737.diff
Mar 28 2025, 9:47 AM
F15427135: D7737.id17501.diff
Mar 23 2025, 1:04 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4205: Implement Phragment
Commits
Restricted Diffusion Commit
rPdabc7ea28dec: Render deleted files in Phragment as disabled
Summary

This updates Phragment so that fragments that are currently considered deleted have a disabled status and have an additional attribute 'Deleted'. It also places this effect on versions (in the history controller) that actually involve deleting the file.

Test Plan

Viewed deleted fragments and versions.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Consider adding $fragment->isDeleted(), since I'd guess we'll need to represent this with slightly more finesse eventually (to be able to represente a file being converted into a directory and back in history).

hach-que updated this revision to Unknown Object (????).Dec 8 2013, 8:52 PM

Added isDeleted()