Render deleted files in Phragment as disabled
ClosedPublic
Actions

Authored by hach-que on Dec 7 2013, 6:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 3:00 AM

	Unknown Object (File)
	Thu, Apr 11, 8:52 AM

	Unknown Object (File)
	Tue, Apr 9, 5:08 AM

	Unknown Object (File)
	Sat, Mar 30, 4:41 PM

	Unknown Object (File)
	Thu, Mar 28, 2:07 PM

	Unknown Object (File)
	Mar 25 2024, 4:43 AM

	Unknown Object (File)
	Mar 20 2024, 5:48 PM

	Unknown Object (File)
	Mar 16 2024, 7:33 PM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4205: Implement Phragment

Commits

Restricted Diffusion Commit
rPdabc7ea28dec: Render deleted files in Phragment as disabled

Summary

This updates Phragment so that fragments that are currently considered deleted have a disabled status and have an additional attribute 'Deleted'. It also places this effect on versions (in the history controller) that actually involve deleting the file.

Test Plan

Viewed deleted fragments and versions.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Consider adding $fragment->isDeleted(), since I'd guess we'll need to represent this with slightly more finesse eventually (to be able to represente a file being converted into a directory and back in history).