Page MenuHomePhabricator

Make sure no one ever misunderstand the "unkonwn symbol" lint message ever again
ClosedPublic

Authored by epriestley on Dec 10 2013, 4:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 6:17 PM
Unknown Object (File)
Fri, Jan 31, 4:43 AM
Unknown Object (File)
Thu, Jan 23, 5:23 AM
Unknown Object (File)
Tue, Jan 21, 11:42 AM
Unknown Object (File)
Mon, Jan 20, 12:18 PM
Unknown Object (File)
Mon, Jan 20, 12:18 PM
Unknown Object (File)
Mon, Jan 20, 12:18 PM
Unknown Object (File)
Thu, Jan 16, 8:39 AM
Subscribers

Details

Summary

A lot of new contributors don't resolve this. Make it easier to resolve, more comprehensive, and more explicit about not being ignorable.

Test Plan
>>> orbital ~/devtools/arcanist $ arc lint
>>> Lint for src/lint/linter/ArcanistPhutilLibraryLinter.php:


   Error  (PHL1) Unknown Symbol
    Use of unknown class 'BlerpBarp'. Common causes are:
  
      - Your libphutil/ is out of date.
        This is the most common cause.
        Update this copy of libphutil: /INSECURE/devtools/libphutil
  
      - Some other library is out of date.
        Update the library this symbol appears in.
  
      - This symbol is misspelled.
        Spell the symbol name correctly.
        Symbol name spelling is case-sensitive.
  
      - This symbol was added recently.
        Run `arc liberate` on the library it was added to.
  
      - This symbol is external. Use `@phutil-external-symbol`.
        Use `grep` to find usage examples of this directive.
  
    *** ALTHOUGH USUALLY EASY TO FIX, THIS IS A SERIOUS ERROR.
    *** THIS ERROR IS YOUR FAULT. YOU MUST RESOLVE IT.

             181               "*** THIS ERROR IS YOUR FAULT. YOU MUST RESOLVE IT.");
             182 
             183             if (false) {
    >>>      184               new BlerpBarp();
             185             }
             186           }
             187         }
>>> orbital ~/devtools/arcanist $

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped