Page MenuHomePhabricator

Make sure no one ever misunderstand the "unkonwn symbol" lint message ever again
ClosedPublic

Authored by epriestley on Dec 10 2013, 4:16 PM.
Tags
None
Referenced Files
F18903133: D7752.diff
Sat, Nov 8, 4:06 AM
F18888022: D7752.id17533.diff
Fri, Nov 7, 6:54 AM
F18856665: D7752.diff
Sat, Nov 1, 10:56 AM
F18436123: D7752.diff
Aug 31 2025, 10:47 AM
F18182838: D7752.id17533.diff
Aug 16 2025, 10:22 AM
F18053966: D7752.id17534.diff
Aug 4 2025, 5:54 AM
F17870523: D7752.id.diff
Jul 28 2025, 2:10 PM
F17852393: D7752.diff
Jul 27 2025, 12:34 PM
Subscribers

Details

Summary

A lot of new contributors don't resolve this. Make it easier to resolve, more comprehensive, and more explicit about not being ignorable.

Test Plan
>>> orbital ~/devtools/arcanist $ arc lint
>>> Lint for src/lint/linter/ArcanistPhutilLibraryLinter.php:


   Error  (PHL1) Unknown Symbol
    Use of unknown class 'BlerpBarp'. Common causes are:
  
      - Your libphutil/ is out of date.
        This is the most common cause.
        Update this copy of libphutil: /INSECURE/devtools/libphutil
  
      - Some other library is out of date.
        Update the library this symbol appears in.
  
      - This symbol is misspelled.
        Spell the symbol name correctly.
        Symbol name spelling is case-sensitive.
  
      - This symbol was added recently.
        Run `arc liberate` on the library it was added to.
  
      - This symbol is external. Use `@phutil-external-symbol`.
        Use `grep` to find usage examples of this directive.
  
    *** ALTHOUGH USUALLY EASY TO FIX, THIS IS A SERIOUS ERROR.
    *** THIS ERROR IS YOUR FAULT. YOU MUST RESOLVE IT.

             181               "*** THIS ERROR IS YOUR FAULT. YOU MUST RESOLVE IT.");
             182 
             183             if (false) {
    >>>      184               new BlerpBarp();
             185             }
             186           }
             187         }
>>> orbital ~/devtools/arcanist $

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped