Page MenuHomePhabricator

Handle "-p port" flag in ssh-connect
ClosedPublic

Authored by epriestley on Dec 2 2013, 7:19 PM.
Tags
None
Referenced Files
F19232578: D7680.diff
Sun, Dec 21, 5:15 PM
F19125741: D7680.id.diff
Wed, Dec 10, 2:13 AM
F19125386: D7680.id17340.diff
Wed, Dec 10, 1:53 AM
F19040668: D7680.diff
Wed, Nov 26, 1:08 PM
F18876444: D7680.diff
Nov 6 2025, 12:48 AM
F18856329: D7680.id.diff
Nov 1 2025, 9:17 AM
F18853997: D7680.diff
Oct 31 2025, 9:21 PM
F18097227: D7680.id.diff
Aug 8 2025, 12:07 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPd59722321fe4: Handle "-p port" flag in ssh-connect
Summary

The documentation is explicit that Git does not pass this flag:

The $GIT_SSH command will be given exactly two arguments: the username@host (or just host) from the URL and the shell command to execute on that remote system.

This isn't true; it does. Accommodate it.

I'll see if I can fix this in the upstream, too.

Test Plan

Ran various ssh-connect commands with -p, etc.

Diff Detail

Branch
port
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

This is already fixed in Git's HEAD. The new documentation reads:

The '$GIT_SSH' command will be given exactly two or
four arguments: the 'username@host' (or just 'host')
from the URL and the shell command to execute on that
remote system, optionally preceded by '-p' (literally) and
the 'port' from the URL when it specifies something other
than the default SSH port.