Page MenuHomePhabricator

Handle "-p port" flag in ssh-connect
ClosedPublic

Authored by epriestley on Dec 2 2013, 7:19 PM.
Tags
None
Referenced Files
F13277553: D7680.diff
Fri, May 31, 11:32 AM
F13252656: D7680.diff
Sat, May 25, 1:56 AM
F13230558: D7680.diff
Mon, May 20, 11:03 PM
F13229288: D7680.id17342.diff
Mon, May 20, 3:29 PM
F13217291: D7680.id17340.diff
Sat, May 18, 4:21 AM
F13210277: D7680.diff
Fri, May 17, 4:41 AM
F13194072: D7680.diff
Sun, May 12, 9:17 PM
F13178877: D7680.diff
Wed, May 8, 8:45 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPd59722321fe4: Handle "-p port" flag in ssh-connect
Summary

The documentation is explicit that Git does not pass this flag:

The $GIT_SSH command will be given exactly two arguments: the username@host (or just host) from the URL and the shell command to execute on that remote system.

This isn't true; it does. Accommodate it.

I'll see if I can fix this in the upstream, too.

Test Plan

Ran various ssh-connect commands with -p, etc.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This is already fixed in Git's HEAD. The new documentation reads:

The '$GIT_SSH' command will be given exactly two or
four arguments: the 'username@host' (or just 'host')
from the URL and the shell command to execute on that
remote system, optionally preceded by '-p' (literally) and
the 'port' from the URL when it specifies something other
than the default SSH port.