Page MenuHomePhabricator

Handle "-p port" flag in ssh-connect
ClosedPublic

Authored by epriestley on Dec 2 2013, 7:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 11:02 PM
Unknown Object (File)
Thu, Dec 19, 3:10 PM
Unknown Object (File)
Thu, Dec 12, 8:07 PM
Unknown Object (File)
Dec 10 2024, 11:03 AM
Unknown Object (File)
Dec 8 2024, 9:00 PM
Unknown Object (File)
Dec 6 2024, 11:46 PM
Unknown Object (File)
Dec 4 2024, 10:02 AM
Unknown Object (File)
Nov 30 2024, 8:18 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPd59722321fe4: Handle "-p port" flag in ssh-connect
Summary

The documentation is explicit that Git does not pass this flag:

The $GIT_SSH command will be given exactly two arguments: the username@host (or just host) from the URL and the shell command to execute on that remote system.

This isn't true; it does. Accommodate it.

I'll see if I can fix this in the upstream, too.

Test Plan

Ran various ssh-connect commands with -p, etc.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This is already fixed in Git's HEAD. The new documentation reads:

The '$GIT_SSH' command will be given exactly two or
four arguments: the 'username@host' (or just 'host')
from the URL and the shell command to execute on that
remote system, optionally preceded by '-p' (literally) and
the 'port' from the URL when it specifies something other
than the default SSH port.