Page MenuHomePhabricator

Handle "-p port" flag in ssh-connect
ClosedPublic

Authored by epriestley on Dec 2 2013, 7:19 PM.
Tags
None
Referenced Files
F19521370: D7680.id17340.diff
Fri, Jan 16, 9:56 PM
F19506619: D7680.id17340.diff
Fri, Jan 9, 4:49 PM
F19506097: D7680.id17342.diff
Fri, Jan 9, 4:40 PM
F19303235: D7680.id17340.diff
Tue, Dec 23, 9:34 PM
F19297237: D7680.id.diff
Tue, Dec 23, 12:35 PM
F19232578: D7680.diff
Sun, Dec 21, 5:15 PM
F19125741: D7680.id.diff
Dec 10 2025, 2:13 AM
F19125386: D7680.id17340.diff
Dec 10 2025, 1:53 AM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPd59722321fe4: Handle "-p port" flag in ssh-connect
Summary

The documentation is explicit that Git does not pass this flag:

The $GIT_SSH command will be given exactly two arguments: the username@host (or just host) from the URL and the shell command to execute on that remote system.

This isn't true; it does. Accommodate it.

I'll see if I can fix this in the upstream, too.

Test Plan

Ran various ssh-connect commands with -p, etc.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This is already fixed in Git's HEAD. The new documentation reads:

The '$GIT_SSH' command will be given exactly two or
four arguments: the 'username@host' (or just 'host')
from the URL and the shell command to execute on that
remote system, optionally preceded by '-p' (literally) and
the 'port' from the URL when it specifies something other
than the default SSH port.