Page MenuHomePhabricator

Handle "-p port" flag in ssh-connect
ClosedPublic

Authored by epriestley on Dec 2 2013, 7:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 2:24 AM
Unknown Object (File)
Sun, Feb 9, 10:41 AM
Unknown Object (File)
Sun, Feb 9, 10:41 AM
Unknown Object (File)
Sun, Feb 9, 10:41 AM
Unknown Object (File)
Sun, Feb 9, 10:41 AM
Unknown Object (File)
Thu, Feb 6, 6:20 AM
Unknown Object (File)
Thu, Feb 6, 4:17 AM
Unknown Object (File)
Tue, Feb 4, 1:12 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPd59722321fe4: Handle "-p port" flag in ssh-connect
Summary

The documentation is explicit that Git does not pass this flag:

The $GIT_SSH command will be given exactly two arguments: the username@host (or just host) from the URL and the shell command to execute on that remote system.

This isn't true; it does. Accommodate it.

I'll see if I can fix this in the upstream, too.

Test Plan

Ran various ssh-connect commands with -p, etc.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This is already fixed in Git's HEAD. The new documentation reads:

The '$GIT_SSH' command will be given exactly two or
four arguments: the 'username@host' (or just 'host')
from the URL and the shell command to execute on that
remote system, optionally preceded by '-p' (literally) and
the 'port' from the URL when it specifies something other
than the default SSH port.