Improve error messages from Filesystem::readRandomBytes()
ClosedPublic
Actions

Authored by epriestley on Nov 25 2013, 8:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Apr 24 2025, 10:53 AM

	Unknown Object (File)
	Apr 24 2025, 8:25 AM

	Unknown Object (File)
	Apr 24 2025, 8:25 AM

	Unknown Object (File)
	Apr 22 2025, 11:56 PM

	Unknown Object (File)
	Apr 20 2025, 9:29 AM

	Unknown Object (File)
	Apr 19 2025, 2:18 PM

	Unknown Object (File)
	Apr 18 2025, 3:01 AM

	Unknown Object (File)
	Mar 22 2025, 1:20 AM

View All Files

Subscribers

aran

Details

Reviewers

hach-que
btrahan

Maniphest Tasks

T4153: Filesystem::readRandomBytes does not work on Windows without php_openssl.dll

Commits

rPHU5fab43a1cccd: Improve error messages from Filesystem::readRandomBytes()

Summary

Fixes T4153. Primarily, raise a better error message on Windows. Also make the function a little stricter and a little better tested.

Test Plan

Unit tests.

Diff Detail

Branch

randmesg

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/filesystem/Filesystem.php:403	XHP31	Use Of PHP 5.3 Features
Error	src/filesystem/Filesystem.php:557	XHP31	Use Of PHP 5.3 Features

Unit

Tests Passed

Event Timeline

Tested on Windows and verified the message appears when OpenSSL is not available.

Closed by commit rPHU5fab43a1cccd (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

filesystem/

Filesystem.php

62 lines

__tests__/

FilesystemTestCase.php

13 lines

Diff 17274

View Options

src/filesystem/Filesystem.php

View Options

src/filesystem/tests/FilesystemTestCase.php

Improve error messages from Filesystem::readRandomBytes()ClosedPublicActions