Improve error messages from Filesystem::readRandomBytes()
ClosedPublic
Actions

Authored by epriestley on Nov 25 2013, 8:58 PM.

Tags

None

Referenced Files

	F13221716: D7650.diff
	Sun, May 19, 2:59 AM

	F13203136: D7650.diff
	Tue, May 14, 11:30 PM

	F13189101: D7650.diff
	Sat, May 11, 5:43 AM

	Unknown Object (File)
	Tue, May 7, 9:16 AM

	Unknown Object (File)
	Fri, May 3, 9:12 AM

	Unknown Object (File)
	Wed, May 1, 9:05 PM

	Unknown Object (File)
	Tue, Apr 30, 12:08 AM

	Unknown Object (File)
	Sat, Apr 27, 4:49 PM

View All Files

Subscribers

aran

Details

Reviewers

hach-que
btrahan

Maniphest Tasks

T4153: Filesystem::readRandomBytes does not work on Windows without php_openssl.dll

Commits

rPHU5fab43a1cccd: Improve error messages from Filesystem::readRandomBytes()

Summary

Fixes T4153. Primarily, raise a better error message on Windows. Also make the function a little stricter and a little better tested.

Test Plan

Unit tests.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Tested on Windows and verified the message appears when OpenSSL is not available.

Closed by commit rPHU5fab43a1cccd (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

filesystem/

Filesystem.php

64 lines

__tests__/

FilesystemTestCase.php

13 lines

Diff 17281

View Options

src/filesystem/Filesystem.php

View Options

src/filesystem/tests/FilesystemTestCase.php

Improve error messages from Filesystem::readRandomBytes()ClosedPublicActions