Page MenuHomePhabricator

Improve error messages from Filesystem::readRandomBytes()
ClosedPublic

Authored by epriestley on Nov 25 2013, 8:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 24 2025, 10:53 AM
Unknown Object (File)
Apr 24 2025, 8:25 AM
Unknown Object (File)
Apr 24 2025, 8:25 AM
Unknown Object (File)
Apr 22 2025, 11:56 PM
Unknown Object (File)
Apr 20 2025, 9:29 AM
Unknown Object (File)
Apr 19 2025, 2:18 PM
Unknown Object (File)
Apr 18 2025, 3:01 AM
Unknown Object (File)
Mar 22 2025, 1:20 AM
Subscribers

Details

Summary

Fixes T4153. Primarily, raise a better error message on Windows. Also make the function a little stricter and a little better tested.

Test Plan

Unit tests.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Tested on Windows and verified the message appears when OpenSSL is not available.