The current format of arc feature is not very friendly to parsing. This adds a json output
format.
Details
Details
- Reviewers
epriestley lifeihuang - Group Reviewers
Blessed Reviewers - Commits
- rARCd30c77d0a871: Add output-json option to arc feature
Run the command and ensure output is valid
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Let's make this --output json to align with arc unit --output json, for consistency. Looks good otherwise.
| src/workflow/ArcanistFeatureWorkflow.php | ||
|---|---|---|
| 353 | This is kind of sketchy, let's just populate it explicitly above. | |
| 355 | Prefer: $dictionary = ipull($dictionary, null, 'name'); ..after the loop. Otherwise, this will produce the wrong results if you have branches named 3, etc. | |