Page MenuHomePhabricator

Add output-json option to arc feature
ClosedPublic

Authored by cdentel on Nov 25 2013, 7:12 PM.
Tags
None
Referenced Files
F14119070: D7647.diff
Fri, Nov 29, 3:04 AM
Unknown Object (File)
Mon, Nov 25, 10:02 PM
Unknown Object (File)
Tue, Nov 19, 1:32 PM
Unknown Object (File)
Fri, Nov 15, 2:47 PM
Unknown Object (File)
Fri, Nov 15, 9:18 AM
Unknown Object (File)
Wed, Nov 13, 2:36 AM
Unknown Object (File)
Mon, Nov 11, 1:02 AM
Unknown Object (File)
Sun, Nov 10, 7:50 AM

Details

Summary

The current format of arc feature is not very friendly to parsing. This adds a json output
format.

Test Plan

Run the command and ensure output is valid

Diff Detail

Branch
master
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Let's make this --output json to align with arc unit --output json, for consistency. Looks good otherwise.

src/workflow/ArcanistFeatureWorkflow.php
353

This is kind of sketchy, let's just populate it explicitly above.

355

Prefer:

$dictionary = ipull($dictionary, null, 'name');

..after the loop. Otherwise, this will produce the wrong results if you have branches named 3, etc.

Awesome - will diff with --output json

src/workflow/ArcanistFeatureWorkflow.php
353

Sounds good.

355

Good to know.

cdentel updated this revision to Unknown Object (????).Nov 25 2013, 7:46 PM

Add parameter to 'output' option, add 'epoch' as key, and use ipull

Thanks! GitHub is no longer the authoritative master, so I'll just pull this.