Paths

Table of Contentst

Add output-json option to arc feature
ClosedPublic
Actions

Authored by cdentel on Nov 25 2013, 7:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 18, 9:22 AM

	Unknown Object (File)
	Tue, Sep 17, 10:44 AM

	Unknown Object (File)
	Tue, Sep 17, 4:02 AM

	Unknown Object (File)
	Sun, Sep 15, 5:01 PM

	Unknown Object (File)
	Sun, Sep 15, 11:58 AM

	Unknown Object (File)
	Sat, Sep 14, 11:41 PM

	Unknown Object (File)
	Sat, Sep 14, 8:05 PM

	Unknown Object (File)
	Sat, Sep 14, 2:58 PM

Subscribers

Details

Reviewers

epriestley
lifeihuang

Group Reviewers

Blessed Reviewers

Commits

rARCd30c77d0a871: Add output-json option to arc feature

Summary

The current format of arc feature is not very friendly to parsing. This adds a json output
format.

Test Plan

Run the command and ensure output is valid

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Let's make this --output json to align with arc unit --output json, for consistency. Looks good otherwise.

src/workflow/ArcanistFeatureWorkflow.php
353	This is kind of sketchy, let's just populate it explicitly above.
355	Prefer: $dictionary = ipull($dictionary, null, 'name'); ..after the loop. Otherwise, this will produce the wrong results if you have branches named `3`, etc.

Awesome - will diff with --output json

src/workflow/ArcanistFeatureWorkflow.php
353	Sounds good.
355	Good to know.

Add parameter to 'output' option, add 'epoch' as key, and use ipull

Thanks! GitHub is no longer the authoritative master, so I'll just pull this.

Closed by commit rARCd30c77d0a871 (authored by @cdentel, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistFeatureWorkflow.php

35 lines

Diff 17271

View Options

src/workflow/ArcanistFeatureWorkflow.php

Add output-json option to arc featureClosedPublicActions