Page MenuHomePhabricator

Recover more flexibly from an already-verified email
ClosedPublic

Authored by epriestley on Nov 21 2013, 10:08 PM.
Tags
None
Referenced Files
F13296654: D7621.diff
Thu, Jun 6, 5:59 PM
F13287510: D7621.diff
Tue, Jun 4, 8:53 AM
F13274962: D7621.diff
Fri, May 31, 4:15 AM
F13260288: D7621.diff
Sun, May 26, 11:43 PM
F13246428: D7621.diff
Thu, May 23, 10:16 AM
F13209038: D7621.id.diff
Thu, May 16, 9:19 PM
F13197342: D7621.diff
Mon, May 13, 12:06 AM
Unknown Object (File)
May 3 2024, 9:14 AM
Subscribers

Details

Summary

Ref T4140. We could hit a redirect loop for a user with a verified primary email address but no "is verified" flag on their account. This shouldn't be possible since the migration should have set the flag, but we can deal with it more gracefully when it does happen (maybe because users forgot to run storage/upgrade, or because of ghosts).

In the controller, check the same flag we check before forcing the user to the controller.

When verifying, allow the verification if either the email or user flag isn't set.

Test Plan

Hit /login/mustverify/; verified an address.

Diff Detail

Branch
veriloop
Lint
Lint Passed
Unit
No Test Coverage