Paths

Table of Contentst

Fix an issue with SVN path construction in the presence of subpath configuration
ClosedPublic
Actions

Authored by epriestley on Nov 21 2013, 9:07 PM.

Tags

None

Referenced Files

	F14059860: D7619.diff
	Sun, Nov 17, 10:04 PM

	F14050003: D7619.diff
	Thu, Nov 14, 3:55 PM

	F14040234: D7619.diff
	Mon, Nov 11, 8:10 AM

	F14036490: D7619.diff
	Sun, Nov 10, 10:27 AM

	F13999438: D7619.diff
	Thu, Oct 24, 2:46 PM

	F13962072: D7619.id.diff
	Oct 15 2024, 7:55 AM

	Unknown Object (File)
	Oct 10 2024, 3:04 PM

	Unknown Object (File)
	Sep 27 2024, 2:30 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
staticshock

Commits

Restricted Diffusion Commit
rPe99c53da2ea2: Fix an issue with SVN path construction in the presence of subpath configuration

Summary

D7590 made path construction more consistent, but affected this callsite if a subpath is configured. Currently, we end up with double @@ in the URI.

Test Plan

Ran unit tests.
Ran bin/repostitory discover.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 21 2013, 10:23 PM

Closed by commit rPe99c53da2ea2 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryDiscoveryEngine.php

5 lines

storage/

PhabricatorRepository.php

4 lines

__tests__/

PhabricatorRepositoryTestCase.php

11 lines

Diff 17208

View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/repository/storage/tests/PhabricatorRepositoryTestCase.php

Fix an issue with SVN path construction in the presence of subpath configurationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17208

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

src/applications/repository/storage/PhabricatorRepository.php

src/applications/repository/storage/__tests__/PhabricatorRepositoryTestCase.php

Fix an issue with SVN path construction in the presence of subpath configuration
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/repository/storage/tests/PhabricatorRepositoryTestCase.php