Paths

Table of Contentst

Fix an issue with SVN path construction in the presence of subpath configuration
ClosedPublic
Actions

Authored by epriestley on Nov 21 2013, 9:07 PM.

Tags

None

Referenced Files

	F18136011: D7619.id17208.diff
	Thu, Aug 14, 12:46 AM

	F18109048: D7619.id.diff
	Mon, Aug 11, 11:28 AM

	F18104783: D7619.diff
	Aug 10 2025, 1:58 PM

	F18089978: D7619.id17208.diff
	Aug 6 2025, 1:37 PM

	F17908775: D7619.id17200.diff
	Jul 29 2025, 1:58 PM

	F17859643: D7619.diff
	Jul 27 2025, 8:57 PM

	Unknown Object (File)
	Jun 16 2025, 10:30 PM

	Unknown Object (File)
	Jun 6 2025, 9:04 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
staticshock

Commits

Restricted Diffusion Commit
rPe99c53da2ea2: Fix an issue with SVN path construction in the presence of subpath configuration

Summary

D7590 made path construction more consistent, but affected this callsite if a subpath is configured. Currently, we end up with double @@ in the URI.

Test Plan

Ran unit tests.
Ran bin/repostitory discover.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 21 2013, 10:23 PM

Closed by commit rPe99c53da2ea2 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryDiscoveryEngine.php

5 lines

storage/

PhabricatorRepository.php

4 lines

__tests__/

PhabricatorRepositoryTestCase.php

11 lines

Diff 17208

View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/repository/storage/tests/PhabricatorRepositoryTestCase.php

Fix an issue with SVN path construction in the presence of subpath configurationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17208

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

src/applications/repository/storage/PhabricatorRepository.php

src/applications/repository/storage/__tests__/PhabricatorRepositoryTestCase.php

Fix an issue with SVN path construction in the presence of subpath configuration
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/repository/storage/tests/PhabricatorRepositoryTestCase.php