Page MenuHomePhabricator
Differential D7619

Fix an issue with SVN path construction in the presence of subpath configuration
ClosedPublic
Actions

Authored by epriestley on Nov 21 2013, 9:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 16 2025, 10:30 PM
Unknown Object (File)
Jun 6 2025, 9:04 AM
Unknown Object (File)
May 5 2025, 9:14 PM
Unknown Object (File)
May 5 2025, 8:56 PM
Unknown Object (File)
Apr 30 2025, 8:45 PM
Unknown Object (File)
Apr 28 2025, 7:09 AM
Unknown Object (File)
Apr 27 2025, 3:04 PM
Unknown Object (File)
Apr 25 2025, 4:51 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
staticshock
Commits
Restricted Diffusion Commit
rPe99c53da2ea2: Fix an issue with SVN path construction in the presence of subpath configuration
Summary

D7590 made path construction more consistent, but affected this callsite if a subpath is configured. Currently, we end up with double @@ in the URI.

Test Plan
  • Ran unit tests.
  • Ran bin/repostitory discover.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
engine/
5 lines
storage/
4 lines
__tests__/
11 lines

Diff 17208

View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/__tests__/PhabricatorRepositoryTestCase.php

Loading...
Phabricator · Built by Phacility