Page MenuHomePhabricator
Differential D7619

Fix an issue with SVN path construction in the presence of subpath configuration
ClosedPublic
Actions

Authored by epriestley on Nov 21 2013, 9:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 28, 2:52 AM
Unknown Object (File)
Mon, Feb 24, 3:05 AM
Unknown Object (File)
Fri, Feb 14, 2:38 PM
Unknown Object (File)
Jan 25 2025, 10:09 PM
Unknown Object (File)
Jan 25 2025, 10:09 PM
Unknown Object (File)
Jan 25 2025, 9:56 PM
Unknown Object (File)
Jan 23 2025, 7:11 AM
Unknown Object (File)
Jan 18 2025, 2:57 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
staticshock
Commits
Restricted Diffusion Commit
rPe99c53da2ea2: Fix an issue with SVN path construction in the presence of subpath configuration
Summary

D7590 made path construction more consistent, but affected this callsite if a subpath is configured. Currently, we end up with double @@ in the URI.

Test Plan
  • Ran unit tests.
  • Ran bin/repostitory discover.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
engine/
5 lines
storage/
4 lines
__tests__/
11 lines

Diff 17208

View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/__tests__/PhabricatorRepositoryTestCase.php

Loading...
Phabricator · Built by Phacility