Paths

Table of Contentst

Fix an issue with SVN path construction in the presence of subpath configuration
ClosedPublic
Actions

Authored by epriestley on Nov 21 2013, 9:07 PM.

Tags

None

Referenced Files

	F19506964: D7619.id17208.diff
	Fri, Jan 9, 5:09 PM

	F19106718: D7619.id.diff
	Dec 7 2025, 1:06 PM

	F19045421: D7619.id.diff
	Nov 27 2025, 7:45 AM

	F19040727: D7619.diff
	Nov 26 2025, 1:30 PM

	F18827196: D7619.id.diff
	Oct 24 2025, 8:19 AM

	F18824478: D7619.diff
	Oct 23 2025, 3:54 PM

	F18755149: D7619.id17200.diff
	Oct 5 2025, 4:03 AM

	F18749091: D7619.id17208.diff
	Oct 4 2025, 2:21 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
staticshock

Commits

Restricted Diffusion Commit
rPe99c53da2ea2: Fix an issue with SVN path construction in the presence of subpath configuration

Summary

D7590 made path construction more consistent, but affected this callsite if a subpath is configured. Currently, we end up with double @@ in the URI.

Test Plan

Ran unit tests.
Ran bin/repostitory discover.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 21 2013, 10:23 PM

Closed by commit rPe99c53da2ea2 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryDiscoveryEngine.php

5 lines

storage/

PhabricatorRepository.php

4 lines

__tests__/

PhabricatorRepositoryTestCase.php

11 lines

Diff 17208

View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/repository/storage/tests/PhabricatorRepositoryTestCase.php

Fix an issue with SVN path construction in the presence of subpath configurationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17208

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

src/applications/repository/storage/PhabricatorRepository.php

src/applications/repository/storage/__tests__/PhabricatorRepositoryTestCase.php

Fix an issue with SVN path construction in the presence of subpath configuration
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/repository/storage/tests/PhabricatorRepositoryTestCase.php